[ https://issues.apache.org/jira/browse/ROCKETMQ-37?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
yukon closed ROCKETMQ-37. ------------------------- > Log output information is not accurate > -------------------------------------- > > Key: ROCKETMQ-37 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-37 > Project: Apache RocketMQ > Issue Type: Improvement > Reporter: QianZhenyu > Assignee: vongosling > Fix For: 4.0.0-incubating > > > 1. in MQClientManager#getAndCreateMQClientInstance line 57 > when generate a new key-value pair for client in factoryTable, if there > was no mapping for the clientId previously, putIfAbsent will return null, and > then output: > "log.warn("Previous MQClientInstance has created for clientId:[{}]", > clientId);" > this is wrong, it should output in condition prev != null > 2. in SubscriptionGroupManager#deleteSubscriptionGroupConfig line 187 > if program execute: > log.warn("delete subscription group failed, subscription group: {} not > exist", old); > variable old is always null , it's useless, so it's better to print groupName -- This message was sent by Atlassian JIRA (v6.3.4#6332)