[jira] [Commented] (ROCKETMQ-72) DefaultMessageStore cannot be properly shutdown when failed in the middle of start()

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ROCKETMQ-72?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15834328#comment-15834328
 ] 

ASF GitHub Bot commented on ROCKETMQ-72:
----------------------------------------

Github user coveralls commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/49
  
    
    [![Coverage 
Status](https://coveralls.io/builds/9795971/badge)](https://coveralls.io/builds/9795971)
    
    Coverage increased (+0.06%) to 30.133% when pulling 
**2b15a5a72c16aa82070f940cf7d329a7460a2c92 on shroman:ROCKETMQ-72** into 
**30cabc77bd99abcf934d822d69030ddcfe38f94a on apache:master**.



> DefaultMessageStore cannot be properly shutdown when failed in the middle of 
> start()
> ------------------------------------------------------------------------------------
>
>                 Key: ROCKETMQ-72
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-72
>             Project: Apache RocketMQ
>          Issue Type: Bug
>            Reporter: Roman Shtykh
>            Assignee: Roman Shtykh
>            Priority: Critical
>
> If {{DefaultMessageStore#start}} fails before it reaches {{this.shutdown = 
> false;}} it remains _true_ and prevents proper shutdown.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)