[
https://issues.apache.org/jira/browse/ROCKETMQ-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15847903#comment-15847903
]
ASF GitHub Bot commented on ROCKETMQ-75:
----------------------------------------
Github user shroman commented on the issue:
https://github.com/apache/incubator-rocketmq/pull/51
@zhouxinyu I agree on moving it to another issue. I will create another PR
for that.
As to making the method private, using reflection for testing is safer than
making a method public solely for testing, IMO. It is even called by another
private method ;)
> RemotingCommand header decoding swallows exceptions
> ---------------------------------------------------
>
> Key: ROCKETMQ-75
> URL: https://issues.apache.org/jira/browse/ROCKETMQ-75
> Project: Apache RocketMQ
> Issue Type: Bug
> Reporter: Roman Shtykh
> Assignee: Roman Shtykh
>
> {{RemotingCommand}} header decoding swallows exceptions, which is ok if you
> want to skip unparseable fields, but then logging is needed.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
