[ 
https://issues.apache.org/jira/browse/ROCKETMQ-75?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15904436#comment-15904436
 ] 

ASF GitHub Bot commented on ROCKETMQ-75:
----------------------------------------

Github user shroman commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/51
  
    @lizhanhui @vongosling I see. I changed the code, please have a look.
    Also, I will try to keep the modules in mind, but we need something not to 
forget they have to be treated differently from others. Can't propose any clean 
solution now.


> RemotingCommand header decoding swallows exceptions
> ---------------------------------------------------
>
>                 Key: ROCKETMQ-75
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-75
>             Project: Apache RocketMQ
>          Issue Type: Bug
>            Reporter: Roman Shtykh
>            Assignee: Roman Shtykh
>
> {{RemotingCommand}} header decoding swallows exceptions, which is ok if you 
> want to skip unparseable fields, but then logging is needed.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to