[ 
https://issues.apache.org/jira/browse/ROCKETMQ-144?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15944430#comment-15944430
 ] 

ASF GitHub Bot commented on ROCKETMQ-144:
-----------------------------------------

Github user shroman commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/79#discussion_r108323945
  
    --- Diff: distribution/pom.xml ---
    @@ -0,0 +1,125 @@
    +<!--
    +  ~ Licensed to the Apache Software Foundation (ASF) under one or more
    --- End diff --
    
    Why do we have these `~` in the header? :)


> Aggregate distribution specific files to a new module
> -----------------------------------------------------
>
>                 Key: ROCKETMQ-144
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-144
>             Project: Apache RocketMQ
>          Issue Type: Improvement
>            Reporter: Zhanhui Li
>            Assignee: Zhanhui Li
>
> When running maven-assembly-plugin, it constantly warns and suggests to use a 
> separate sub-module to aggregate packaging files, which are scattered in the 
> parent projects. Usage of this is exemplified 
> http://maven.apache.org/plugins/maven-assembly-plugin/examples/multimodule/module-binary-inclusion-simple.html
>  



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to