[ 
https://issues.apache.org/jira/browse/ROCKETMQ-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15964025#comment-15964025
 ] 

ASF GitHub Bot commented on ROCKETMQ-121:
-----------------------------------------

Github user vsair commented on a diff in the pull request:

    https://github.com/apache/incubator-rocketmq/pull/82#discussion_r110845213
  
    --- Diff: 
filter/src/main/java/org/apache/rocketmq/filter/util/BloomFilter.java ---
    @@ -0,0 +1,332 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.rocketmq.filter.util;
    +
    +import java.util.Arrays;
    +
    +/**
    + * Simple implement of bloom filter.
    + */
    +public class BloomFilter {
    --- End diff --
    
    Hi, I replaced HashAlgorithm to Guava Hashing.murmur3_128. Most classes of 
Guava's BloomFilter are private and final, which could not be included by 
RocketMQ, such as BitArray saved in store.So I didn't use it.


> Support message filtering based on SQL92
> ----------------------------------------
>
>                 Key: ROCKETMQ-121
>                 URL: https://issues.apache.org/jira/browse/ROCKETMQ-121
>             Project: Apache RocketMQ
>          Issue Type: Wish
>          Components: rocketmq-client, rocketmq-store
>            Reporter: yukon
>            Assignee: vongosling
>            Priority: Minor
>
> So far, RocketMQ only support message filtering feature by `TAG`, but one 
> message only can own one tag, this is too limited to meet complex business 
> requirements.
> So, we want to define and implement a reasonable filter language based on a 
> subset of the SQL 92 expression syntax to support customized message 
> filtering.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to