[ https://issues.apache.org/jira/browse/ROCKETMQ-264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16139844#comment-16139844 ]
ASF GitHub Bot commented on ROCKETMQ-264: ----------------------------------------- Github user lindzh commented on a diff in the pull request: https://github.com/apache/incubator-rocketmq/pull/145#discussion_r134974719 --- Diff: broker/src/test/java/org/apache/rocketmq/broker/BrokerControllerTest.java --- @@ -37,16 +37,14 @@ */ @Test public void testBrokerRestart() throws Exception { - for (int i = 0; i < 2; i++) { - BrokerController brokerController = new BrokerController( - new BrokerConfig(), - new NettyServerConfig(), - new NettyClientConfig(), - new MessageStoreConfig()); - assertThat(brokerController.initialize()); - brokerController.start(); - brokerController.shutdown(); - } + BrokerController brokerController = new BrokerController( --- End diff -- As there is more whole startup in test case , I think there no need to do this. Any questions?IMO > Unit test cost too long and there is exception in unit test > ----------------------------------------------------------- > > Key: ROCKETMQ-264 > URL: https://issues.apache.org/jira/browse/ROCKETMQ-264 > Project: Apache RocketMQ > Issue Type: Improvement > Reporter: lindzh > Assignee: vongosling > > When run mvn test , it cost too much time and some times there is exception > in unit test and the test result is pass -- This message was sent by Atlassian JIRA (v6.4.14#64029)