yishayw commented on PR #1222: URL: https://github.com/apache/royale-asjs/pull/1222#issuecomment-1589732775
@cdouine39 , thanks for this pull request. One thing to remember when dealing with Basic beads (ToolTipBead is under the Basic library) is that we strive to keep basic functionality and minimal code. The goal is that applications written with Basic components will not contain unused code and will load as fast as possible. That's what's called the Pay As You Go (PAYG) principle, which is different from 'just in case' code which can have an adverse effect on performance. Therefore, adding 2 lines of code, 'just in case' there may be a multi-lined tooltip does not comply with the PAYG principle. The solution could be to create a more specialized bead (which could still be part of the Basic library) to deal with multi-line tooltips (e.g. MultilineTooTipBead), which might extend TooltipBead to add these lines of code. That way applications that require multi-line tooltips can use that bead, but Basic applications with short tooltips will used the regular TooltipBad and will not load ' just in case' code they are not using. So to make a long story short, I suggest to add your code to a new bead which extends ToolTipBead, instead of changing ToolTipBead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@royale.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
