furqaankhan commented on code in PR #1474:
URL: https://github.com/apache/sedona/pull/1474#discussion_r1634043599


##########
common/src/test/java/org/apache/sedona/common/FunctionsTest.java:
##########
@@ -2861,6 +2862,44 @@ public void locateAlong() throws ParseException {
         assertEquals("Polygon geometry type not supported, supported types 
are: (Multi)Point and (Multi)LineString.", e.getMessage());
     }
 
+    @Test
+    public void isValidDetail() throws ParseException {
+        // Valid geometry
+        Geometry validGeom = GEOMETRY_FACTORY.createPolygon(coordArray(30, 10, 
40, 40, 20, 40, 10, 20, 30, 10));
+        ValidDetail actualValidDetail = Functions.isValidDetail(validGeom);
+        ValidDetail expectedValidDetail = new ValidDetail(true, null, null);
+        assertTrue(expectedValidDetail.equals(actualValidDetail));
+
+        Integer OGC_SFS_VALIDITY = 0;
+        Integer ESRI_VALIDITY = 1;
+
+        actualValidDetail = Functions.isValidDetail(validGeom, 
OGC_SFS_VALIDITY);

Review Comment:
   What do you mean?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@sedona.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to