Kontinuation commented on code in PR #597:
URL: https://github.com/apache/sedona-db/pull/597#discussion_r2794272776
##########
rust/sedona-raster-functions/src/rs_envelope.rs:
##########
@@ -78,19 +78,38 @@ impl SedonaScalarKernel for RsEnvelope {
executor.num_iterations(),
executor.num_iterations() * bytes_per_poly,
);
+ let mut crs_builder =
StringViewBuilder::with_capacity(executor.num_iterations());
executor.execute_raster_void(|_i, raster_opt| {
match raster_opt {
Some(raster) => {
create_envelope_wkb(raster, &mut builder)?;
builder.append_value([]);
Review Comment:
Perhaps the helper function `create_envelope_wkb` has a poor name. I'll
rename it to `write_envelope_wkb`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
