yutannihilation opened a new pull request, #606:
URL: https://github.com/apache/sedona-db/pull/606
Part of #554
After some struggle, I now think this requires to modify `CrsTransform` to
- `transform_coord_3d()` takes the dimension of the input coordinate because
otherwise there's no way to distinguish if the z value of `coord` is from the
original input or is filled.
- I think `transform_coord()` doesn't need this, but I'm not fully sure
- new `output_dim()` returns the dimension of the output
```rust
pub trait CrsTransform: std::fmt::Debug {
fn transform_coord(
&self,
coord: &mut (f64, f64),
) -> Result<(), SedonaGeometryError>;
fn transform_coord_3d(
&self,
coord: &mut (f64, f64, f64),
input_dims: Dimensions, // new
) -> Result<(), SedonaGeometryError>;
// new
fn output_dim(&self) -> Option<Dimensions>;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
