Kontinuation commented on PR #562: URL: https://github.com/apache/sedona-db/pull/562#issuecomment-3894479954
I prefer fixing filter pushdown for KNN join in a separate PR, since this PR is already self-contained and pretty large. We can do the following things in a follow-up PR: 1. Prepending a rule for converting regular join to SpatialJoinExecPlan to prevent incorrect filter pushdown 2. Disallow join conditions such as `<expr> AND ST_KNN(...)`. We can allow `ST_KNN(...) AND <expr>` and apply `Filter(<expr>)` to the result of KNN join. 3. Preserving the regular join node for non-KNN spatial joins to allow DataFusion's builtin passes to optimize it, and convert it to SpatialJoinExecPlan in the last few optimization rules 4. Adding filter pushdown test cases, validating that filter pushdown happens for non-KNN join, but not for KNN join. This stage does not support pushing filters down to the query side of the KNN join. We can implement the optimization rules discussed by https://ieeexplore.ieee.org/document/5447873 after fixing the most basic semantic correctness issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
