Kontinuation commented on code in PR #611:
URL: https://github.com/apache/sedona-db/pull/611#discussion_r2814855320
##########
rust/sedona-spatial-join/src/planner/logical_plan_node.rs:
##########
@@ -106,6 +106,15 @@ impl UserDefinedLogicalNodeCore for SpatialJoinPlanNode {
)
}
+ fn necessary_children_exprs(&self, _output_columns: &[usize]) ->
Option<Vec<Vec<usize>>> {
+ // Request all columns from both children. This ensures the optimizer
+ // recurses into children while preserving all columns needed by the
+ // join filter and output schema.
+ let left_indices: Vec<usize> =
(0..self.left.schema().fields().len()).collect();
+ let right_indices: Vec<usize> =
(0..self.right.schema().fields().len()).collect();
+ Some(vec![left_indices, right_indices])
+ }
Review Comment:
This is for working around a bug in DataFusion. I'll submit a patch later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
