Copilot commented on code in PR #2658:
URL: https://github.com/apache/sedona/pull/2658#discussion_r2824014387
##########
spark/common/src/main/java/org/apache/sedona/core/utils/SedonaConf.java:
##########
@@ -342,4 +355,36 @@ public Boolean getLibPostalUseSenzing() {
public CRSTransformMode getCRSTransformMode() {
return crsTransformMode;
}
+
+ /**
+ * Get the base URL for the URL-based CRS provider. When non-empty, a {@code
UrlCRSProvider} is
+ * registered to resolve SRID definitions from this HTTP(S) endpoint.
+ *
+ * @return The base URL, or empty string if disabled
+ * @since 1.9.0
+ */
+ public String getCrsUrlBase() {
+ return crsUrlBase;
+ }
+
+ /**
+ * Get the path template for the URL-based CRS provider. Supports
placeholders: {@code
+ * {authority}}, {@code {AUTHORITY}}, {@code {code}}.
+ *
+ * @return The path template (default: "/{authority}/{code}.json")
+ * @since 1.9.0
+ */
Review Comment:
The JavaDoc for getCrsUrlPathTemplate() mentions three placeholders:
`{authority}`, `{AUTHORITY}`, and `{code}`, but the documentation in
Parameter.md only mentions `{authority}` and `{code}`. Please verify whether
the uppercase `{AUTHORITY}` placeholder is actually supported by the
UrlCRSProvider in proj4sedona 0.0.4, and if so, update Parameter.md to document
it. If only lowercase is supported, remove the mention of `{AUTHORITY}` from
the JavaDoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
