[
https://issues.apache.org/jira/browse/SENTRY-1184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15228922#comment-15228922
]
Sravya Tirukkovalur commented on SENTRY-1184:
---------------------------------------------
Attached an initial patch which does following:
If oldName == newName, oldPath != newPath. This is treated as regular
newName.add(newPath), newName.delete(oldPath), so renameAuthz is not called for
this case.
If oldName != newName renameAuthz is called which does the following:
oldPath == newPath (rename external table) =>new_table.add(new_path),
new_table.add(old_table_partition_paths), old_table.dropAllPaths
oldPath != newPath ( rename managed table) => new_table.add(new_path),
old_table.dropAllPaths
- Also added a basic test case.
[~hahao], [~dapengsun] I plan to add more tests, but can you guys take a quick
look to see if the approach looks good? Thanks!
> NPE in HMSPaths#renameAuthzObject
> ---------------------------------
>
> Key: SENTRY-1184
> URL: https://issues.apache.org/jira/browse/SENTRY-1184
> Project: Sentry
> Issue Type: Bug
> Reporter: Sravya Tirukkovalur
> Assignee: Sravya Tirukkovalur
> Attachments: SENTRY-1184.001-branch-1.5.1.patch,
> SENTRY-1184.002.patch, SENTRY-1184.1.patch
>
>
> java.lang.NullPointerException
> at org.apache.sentry.hdfs.HMSPaths.renameAuthzObject(HMSPaths.java:571)
> at
> org.apache.sentry.hdfs.UpdateableAuthzPaths.applyPartialUpdate(UpdateableAuthzPaths.java:106)
> at
> org.apache.sentry.hdfs.UpdateableAuthzPaths.updatePartial(UpdateableAuthzPaths.java:75)
> at
> org.apache.sentry.hdfs.SentryAuthorizationInfo.processUpdates(SentryAuthorizationInfo.java:174)
> at
> org.apache.sentry.hdfs.SentryAuthorizationInfo.update(SentryAuthorizationInfo.java:131)
> at
> org.apache.sentry.hdfs.SentryAuthorizationInfo.run(SentryAuthorizationInfo.java:193)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
