[ https://issues.apache.org/jira/browse/SENTRY-1556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15726294#comment-15726294 ]
kalyan kumar kalvagadda commented on SENTRY-1556: ------------------------------------------------- I strongly agree with the approach-1 mentioned in the description unless there is a reason not to take that approach. > Simplify privilege cleaning > --------------------------- > > Key: SENTRY-1556 > URL: https://issues.apache.org/jira/browse/SENTRY-1556 > Project: Sentry > Issue Type: Improvement > Components: Sentry > Affects Versions: 1.8.0, sentry-ha-redesign > Reporter: Alexander Kolbasov > Assignee: kalyan kumar kalvagadda > Priority: Minor > > The SentryStore class has a privCleaner that cleans up orphaned privileges. > Currently cleaning is happening after 50 notification requests are sent and > it uses locking to synchronize. > I think the whole thing can be simplified: > 1) We should consider whether it is possible to clean up a privilege simply > when we see that there are no roles associated with it. In this case we do > not need this at all. > 2) We can simply run a periodic job to clean up orphaned privileges and > groups (which are not cleaned up at all now). -- This message was sent by Atlassian JIRA (v6.3.4#6332)