[ https://issues.apache.org/jira/browse/SENTRY-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alexander Kolbasov updated SENTRY-1515: --------------------------------------- Status: Patch Available (was: In Progress) Addressed code review comments. > Cleanup exception handling in SentryStore > ----------------------------------------- > > Key: SENTRY-1515 > URL: https://issues.apache.org/jira/browse/SENTRY-1515 > Project: Sentry > Issue Type: Bug > Components: Sentry > Affects Versions: sentry-ha-redesign > Reporter: Alexander Kolbasov > Assignee: Alexander Kolbasov > Attachments: SENTRY-1515.001.patch, SENTRY-1515.002.patch > > > The changes to SENTRY-1422 and SENTRY-1512 changed the semantics of several > API calls: > - hasAnyServerPrivileges > - getMSentryPrivileges > - getMSentryPrivilegesByAuth > - getRoleNamesForGroups > - retrieveFullPrivilegeImage > - retrieveFullRoleImage > - retrieveFullPathsImage > - getAllRoleNames > Previously they were not marked as throwing Exception, but they still could > do it. With the change they now ignore exceptions and just log them which may > not be the right thing to do. > Instead they should be marked as throwing exceptions which has consequence > for broader APIs which should be marked as well. -- This message was sent by Atlassian JIRA (v6.3.4#6332)