[ 
https://issues.apache.org/jira/browse/SENTRY-1632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15872064#comment-15872064
 ] 

Vamsee Yarlagadda commented on SENTRY-1632:
-------------------------------------------

LGTM. Ship It!

Small suggestion: Do we want to name the properties with "millis" suffix to 
explicitly call out the units as well to make it more clear?

{quote}
public static final String SENTRY_HMSFOLLOWER_INIT_DELAY = 
"sentry.hmsfollower.init.delay.millis";
public static final long SENTRY_HMSFOLLOWER_INIT_DELAY_DEFAULT = 60000;
public static final String SENTRY_HMSFOLLOWER_INTERVAL = 
"sentry.hmsfollower.interval.millis";
public static final long SENTRY_HMSFOLLOWER_INTERVAL_DEFAULT = 500;
{quote}

> Make HMSFollower initialDelay and run period configurable
> ---------------------------------------------------------
>
>                 Key: SENTRY-1632
>                 URL: https://issues.apache.org/jira/browse/SENTRY-1632
>             Project: Sentry
>          Issue Type: Sub-task
>          Components: Hdfs Plugin
>    Affects Versions: sentry-ha-redesign
>            Reporter: Hao Hao
>            Assignee: Hao Hao
>             Fix For: sentry-ha-redesign
>
>         Attachments: SENTRY-1632.001-sentry-ha-redesign.patch
>
>
> Currently HMSFollower is scheduled to run every 500 milliseconds, we should 
> make it configurable.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to