[
https://issues.apache.org/jira/browse/SENTRY-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15926769#comment-15926769
]
Hadoop QA commented on SENTRY-1663:
-----------------------------------
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12858902/SENTRY-1663.001.patch
against master.
{color:green}Overall:{color} +1 all checks pass
{color:green}SUCCESS:{color} all tests passed
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/2442/console
This message is automatically generated.
> UpdateableAuthzPermissions has mutable static fields
> ----------------------------------------------------
>
> Key: SENTRY-1663
> URL: https://issues.apache.org/jira/browse/SENTRY-1663
> Project: Sentry
> Issue Type: Bug
> Components: Sentry
> Affects Versions: 1.8.0
> Reporter: Alexander Kolbasov
> Assignee: Jan Hentschel
> Priority: Minor
> Labels: bite-sized, newbie
> Attachments: SENTRY-1663.001.patch
>
>
> UpdateableAuthzPermissions has the following code:
> {code}
> public static final Map<String, FsAction> ACTION_MAPPING = new
> HashMap<String, FsAction>();
>
> static {
> ACTION_MAPPING.put("ALL", FsAction.ALL);
> ACTION_MAPPING.put("*", FsAction.ALL);
> ACTION_MAPPING.put("SELECT", FsAction.READ_EXECUTE);
> ACTION_MAPPING.put("select", FsAction.READ_EXECUTE);
> ACTION_MAPPING.put("INSERT", FsAction.WRITE_EXECUTE);
> ACTION_MAPPING.put("insert", FsAction.WRITE_EXECUTE);
> }
> {code}
> It should use ImmutableMap instead.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
