[ https://issues.apache.org/jira/browse/SENTRY-1593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15949804#comment-15949804 ]
Alexander Kolbasov commented on SENTRY-1593: -------------------------------------------- [~kkalyan] It is very difficult to review such big patch which involves moving files around as well as changing them. Can you refactor the patch in two parts: 1) Moving all files around as you need without changing them (other then the changes necessary for the move) 2) Actually changing files for the feature. The first one should be a very straightforward code review, the second can concentrate on the actual meat of the change. > Implement client failover for Generic and NN clients > ---------------------------------------------------- > > Key: SENTRY-1593 > URL: https://issues.apache.org/jira/browse/SENTRY-1593 > Project: Sentry > Issue Type: Sub-task > Components: Sentry > Affects Versions: sentry-ha-redesign > Reporter: Alexander Kolbasov > Assignee: kalyan kumar kalvagadda > Labels: HA > Fix For: sentry-ha-redesign > > Attachments: old_service_client_class_diagram.png, > SENTRY-1593.001-sentry-ha-redesign.patch, > SENTRY-1593.002-sentry-ha-redesign.patch, > SENTRY-1593.003-sentry-ha-redesign.patch, > SENTRY-1593.004-sentry-ha-redesign.patch, > SENTRY-1593.005-sentry-ha-redesign.patch, service_client_class_diagram.png > > > We need to have client failover logic for Generic service clients and Name > Node clients. Currently only db policy clients have it implemented. -- This message was sent by Atlassian JIRA (v6.3.15#6346)