[ 
https://issues.apache.org/jira/browse/SENTRY-378?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15957498#comment-15957498
 ] 

Alexander Kolbasov commented on SENTRY-378:
-------------------------------------------

I think that the failure is caused by the change of the exception type. 

{code}
SentryAccessDeniedException extends SentryUserException
SentryUserException extends Exception
{code}

But

{code}
SentryConfigurationException extends ConfigurationException
ConfigurationException extends ShiroException
ShiroException extends RuntimeException
{code}

So SentryAccessDeniedException is checked and SentryConfigurationException 
isn't.

> Clean up the usage of SentryAccessDeniedException
> -------------------------------------------------
>
>                 Key: SENTRY-378
>                 URL: https://issues.apache.org/jira/browse/SENTRY-378
>             Project: Sentry
>          Issue Type: Improvement
>    Affects Versions: 1.4.0
>            Reporter: Sravya Tirukkovalur
>            Assignee: Jan Hentschel
>            Priority: Minor
>             Fix For: 1.8.0
>
>         Attachments: SENTRY-378.001.patch, SENTRY-378.002.patch, 
> SENTRY-378.002.patch
>
>
> SentryAccessDeniedException is mostly used when user does is not part of 
> sentry admin group, but is trying to create role, grant role or grant 
> privilege.  Although I see that it is also used else where, there is scope 
> for some clean up. For example:
> SentryStore.getMSentryVersion()



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to