[ https://issues.apache.org/jira/browse/SENTRY-1556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15968366#comment-15968366 ]
Hadoop QA commented on SENTRY-1556: ----------------------------------- Here are the results of testing the latest attachment https://issues.apache.org/jira/secure/attachment/12863386/SENTRY-1556.002-sentry-ha-redesign.patch against sentry-ha-redesign. {color:red}Overall:{color} -1 due to 3 errors {color:red}ERROR:{color} mvn test exited 1 {color:red}ERROR:{color} Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore {color:red}ERROR:{color} Failed: org.apache.sentry.provider.db.service.persistent.TestSentryStore Console output: https://builds.apache.org/job/PreCommit-SENTRY-Build/2515/console This message is automatically generated. > Simplify privilege cleaning > --------------------------- > > Key: SENTRY-1556 > URL: https://issues.apache.org/jira/browse/SENTRY-1556 > Project: Sentry > Issue Type: Improvement > Components: Sentry > Affects Versions: 1.8.0, sentry-ha-redesign > Reporter: Alexander Kolbasov > Assignee: kalyan kumar kalvagadda > Priority: Minor > Fix For: 1.8.0 > > Attachments: SENTRY-1556.001-sentry-ha-redesign.patch, > SENTRY-1556.002.patch, SENTRY-1556.002-sentry-ha-redesign.patch, > SENTRY-1556.003.patch, SENTRY-1556.004.patch, SENTRY-1556.005.patch, > SENTRY-1556.006.patch, SENTRY-1556.007.patch, SENTRY-1556.008.patch > > > The SentryStore class has a privCleaner that cleans up orphaned privileges. > Currently cleaning is happening after 50 notification requests are sent and > it uses locking to synchronize. > I think the whole thing can be simplified: > 1) We should consider whether it is possible to clean up a privilege simply > when we see that there are no roles associated with it. In this case we do > not need this at all. > 2) We can simply run a periodic job to clean up orphaned privileges and > groups (which are not cleaned up at all now). -- This message was sent by Atlassian JIRA (v6.3.15#6346)