[
https://issues.apache.org/jira/browse/SENTRY-1743?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Alexander Kolbasov updated SENTRY-1743:
---------------------------------------
Status: Patch Available (was: Open)
> Two SentryStore instances are one too many
> ------------------------------------------
>
> Key: SENTRY-1743
> URL: https://issues.apache.org/jira/browse/SENTRY-1743
> Project: Sentry
> Issue Type: Bug
> Components: Sentry
> Affects Versions: 1.8.0, sentry-ha-redesign
> Reporter: Alexander Kolbasov
> Assignee: Alexander Kolbasov
> Attachments: SENTRY-1743.001.patch, SENTRY-1743.001.patch,
> SENTRY-1743.001.patch
>
>
> It turns out that we are creating multiple SentryStore instances each with
> its own Persistence manager factory which is wrong - we should create only
> one.
> 1) SentryService creates one in its constructor
> 2) DelegateSentryStore creates another one which is rather bad
> 3) SentryAdminServlet creates another one every time it shows some info
> We should use a single one.
> There are also some instances created by tests:
> - TestSentryStore creates one - this is probably Ok
> - TestSentryStoreImportExport - this is probably Ok as well
> - TestSentryVersion - this may be Ok, but probably this should be merged to
> TestSentryStore
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
