[
https://issues.apache.org/jira/browse/SENTRY-2015?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16215257#comment-16215257
]
Hadoop QA commented on SENTRY-2015:
-----------------------------------
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12893521/SENTRY-2015.patch
against master.
{color:green}Overall:{color} +1 all checks pass
{color:green}SUCCESS:{color} all tests passed
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/3370/console
This message is automatically generated.
> Refactor Command implementations
> --------------------------------
>
> Key: SENTRY-2015
> URL: https://issues.apache.org/jira/browse/SENTRY-2015
> Project: Sentry
> Issue Type: Improvement
> Reporter: Colm O hEigeartaigh
> Assignee: Colm O hEigeartaigh
> Fix For: 2.0.0
>
> Attachments: SENTRY-2015.patch
>
>
> Right now, we have different Command implementations for each possible Shell
> command for both the Hive and Generic versions. Instead, we should have a
> single interface which encapsulates all of the different Commands, and then
> two implementations for Hive + Generic. Apart from having a lot less simple
> classes, this means that I can re-use this interface for the Sentry CLI work.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)