[ 
https://issues.apache.org/jira/browse/SENTRY-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244965#comment-16244965
 ] 

Sergio Peña commented on SENTRY-2039:
-------------------------------------

Probably true. 

I picked what it was already committed from Sentry 1.7 and lower versions.
https://github.com/apache/sentry/blob/branch-1.7.0/sentry-policy/sentry-policy-common/src/main/java/org/apache/sentry/policy/common/KeyValue.java#L87

But we could lower the case in the constructor as well to save time on the 
equals() method. Should I go with that approach or keep it consistent with 
older code?

> KeyValue is case sensitive and it causes incompatibility issues with external 
> components
> ----------------------------------------------------------------------------------------
>
>                 Key: SENTRY-2039
>                 URL: https://issues.apache.org/jira/browse/SENTRY-2039
>             Project: Sentry
>          Issue Type: Bug
>          Components: Sentry
>    Affects Versions: 1.8.0
>            Reporter: Sergio Peña
>            Assignee: Sergio Peña
>         Attachments: SENTRY-2039.1.patch, SENTRY-2039.2.patch
>
>
> A refactor done on SENTRY-999 changed the way KeyValue.equals() checks for 
> equality. It used to be case insensitive and now it is case sensitive. This 
> may cause issues (like hbase indexer) when policies are written with case 
> insensitive.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to