[ https://issues.apache.org/jira/browse/SENTRY-2047?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arjun Mishra updated SENTRY-2047: --------------------------------- Status: Patch Available (was: Open) > isTableEmptyCore method ins SentryStore has references to MAuthzPathsMapping > when it should be generic > ------------------------------------------------------------------------------------------------------ > > Key: SENTRY-2047 > URL: https://issues.apache.org/jira/browse/SENTRY-2047 > Project: Sentry > Issue Type: Bug > Components: Sentry > Affects Versions: 2.0.0 > Reporter: Arjun Mishra > Assignee: Arjun Mishra > Labels: newbie > Attachments: SENTRY-2047.01.patch > > > Current isTableEmpty implementation is below > {noformat} > private boolean isTableEmptyCore(PersistenceManager pm, Class clazz) { > Query query = pm.newQuery(clazz); > query.addExtension(LOAD_RESULTS_AT_COMMIT, "false"); > // setRange is implemented efficiently for MySQL, Postgresql (using the > LIMIT SQL keyword) > // and Oracle (using the ROWNUM keyword), with the query only finding the > objects required > // by the user directly in the datastore. For other RDBMS the query will > retrieve all > // objects up to the "to" record, and will not pass any unnecessary > objects that are before > // the "from" record. > query.setRange(0, 1); > return ((List<MAuthzPathsMapping>) query.execute()).isEmpty(); > } > {noformat} > We seem to be casting query.execute to a List<MAuthzPathsMapping> when there > is no need for it -- This message was sent by Atlassian JIRA (v6.4.14#64029)