[
https://issues.apache.org/jira/browse/SENTRY-2072?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16267378#comment-16267378
]
Sergio Peña commented on SENTRY-2072:
-------------------------------------
It shouldn't be that difficult if we use only SLF4J api.
Here's some info about SLF4J vs LOG4J:
https://howtodoinjava.com/log4j/slf4j-vs-log4j-which-one-is-better/
I saw that Sentry uses SLF4J in some places and LOG4J in other places. SLF4J is
just an interface and it chooses the LOG4J implementation at runtime based on
what is stored in the sentry lib/ directory. Also, the SentryMain, which checks
for the log4j properties file, has some log4j v1 specific logic.
It should be safe for now to exclude those log4j2 dependencies. I would like to
see this only SLF4J support on 2.1 so we can choose at runtime any log4j
version we want. That would be a really good feature.
> log4j2 dependencies brought by Hive 2 are causing conflicts with Sentry log4j
> -----------------------------------------------------------------------------
>
> Key: SENTRY-2072
> URL: https://issues.apache.org/jira/browse/SENTRY-2072
> Project: Sentry
> Issue Type: Bug
> Components: Sentry
> Affects Versions: 2.0.0
> Reporter: Sergio Peña
> Assignee: kalyan kumar kalvagadda
> Priority: Blocker
> Fix For: 2.0.0
>
> Attachments: SENTRY-2072.001.patch
>
>
> While testing Sentry 2.0, I found that the logging was not working correctly
> due to some log4j2 dependencies that were added on the classpath by Hive 2
> dependency.
> Sentry has a mix of log4j and SLF4J api usage, so having these mix of
> dependencies have conflict with the Sentry logging. We should exclude these
> log4j2 dependencies for the Sentry 2.0 release.
> The libraries that were added and should be excluded are:
> log4j-1.2-api-2.6.2.jar
> log4j-api-2.6.2.jar
> log4j-core-2.6.2.jar
> log4j-slf4j-impl-2.6.2.jar
> log4j-web-2.6.2.jar
> The only library that should exist on the classpath is:
> log4j-1.2.16.jar
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
