[ 
https://issues.apache.org/jira/browse/SENTRY-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519434#comment-16519434
 ] 

Arjun Mishra commented on SENTRY-2231:
--------------------------------------

Local tests passed
{noformat}
$ mvn -f sentry-service/sentry-service-server/pom.xml test

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------
[INFO] Running 
org.apache.sentry.provider.db.log.appender.TestRollingFileWithoutDeleteAppender
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.212 s 
- in 
org.apache.sentry.provider.db.log.appender.TestRollingFileWithoutDeleteAppender
[INFO] Running org.apache.sentry.provider.db.log.util.TestCommandUtil
[INFO] Tests run: 15, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.121 s 
- in org.apache.sentry.provider.db.log.util.TestCommandUtil
[INFO] Running org.apache.sentry.provider.db.log.entity.TestJsonLogEntityFactory
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.599 s 
- in org.apache.sentry.provider.db.log.entity.TestJsonLogEntityFactory
[INFO] Running 
org.apache.sentry.provider.db.log.entity.TestGMAuditMetadataLogEntity
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.33 s - 
in org.apache.sentry.provider.db.log.entity.TestGMAuditMetadataLogEntity
[INFO] Running 
org.apache.sentry.provider.db.log.entity.TestDbAuditMetadataLogEntity
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.317 s 
- in org.apache.sentry.provider.db.log.entity.TestDbAuditMetadataLogEntity
[INFO] Running 
org.apache.sentry.provider.db.log.entity.TestJsonLogEntityFactoryGM
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.581 s 
- in org.apache.sentry.provider.db.log.entity.TestJsonLogEntityFactoryGM
[INFO] Running 
org.apache.sentry.provider.db.generic.service.persistent.TestSentryGMPrivilege
[INFO] Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.107 s 
- in 
org.apache.sentry.provider.db.generic.service.persistent.TestSentryGMPrivilege
[INFO] Running 
org.apache.sentry.provider.db.generic.service.persistent.TestPrivilegeOperatePersistence
[INFO] Tests run: 21, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 11.007 
s - in 
org.apache.sentry.provider.db.generic.service.persistent.TestPrivilegeOperatePersistence
[INFO] Running 
org.apache.sentry.provider.db.generic.service.persistent.TestSentryRole
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 9.492 s 
- in org.apache.sentry.provider.db.generic.service.persistent.TestSentryRole
[INFO] Running 
org.apache.sentry.provider.db.generic.service.persistent.TestDelegateSentryStore
[INFO] Tests run: 10, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 5.125 s 
- in 
org.apache.sentry.provider.db.generic.service.persistent.TestDelegateSentryStore
[INFO] Running 
org.apache.sentry.provider.db.service.persistent.TestHMSFollowerSentryStoreIntegration
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.782 s 
- in 
org.apache.sentry.provider.db.service.persistent.TestHMSFollowerSentryStoreIntegration
[INFO] Running 
org.apache.sentry.provider.db.service.persistent.TestSentryStoreToAuthorizable
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.184 s 
- in 
org.apache.sentry.provider.db.service.persistent.TestSentryStoreToAuthorizable
[INFO] Running 
org.apache.sentry.provider.db.service.persistent.TestSentryStoreImportExport
[INFO] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.862 s 
- in 
org.apache.sentry.provider.db.service.persistent.TestSentryStoreImportExport
[INFO] Running 
org.apache.sentry.provider.db.service.persistent.TestLeaderStatusMonitor
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 50.411 s 
- in org.apache.sentry.provider.db.service.persistent.TestLeaderStatusMonitor
[INFO] Running org.apache.sentry.provider.db.service.persistent.TestHMSFollower
[WARNING] Tests run: 21, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 
1.926 s - in org.apache.sentry.provider.db.service.persistent.TestHMSFollower
[INFO] Running 
org.apache.sentry.provider.db.service.persistent.TestSentryVersion
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.799 s 
- in org.apache.sentry.provider.db.service.persistent.TestSentryVersion
[INFO] Running 
org.apache.sentry.provider.db.service.persistent.TestNotificationProcessor
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.635 s 
- in org.apache.sentry.provider.db.service.persistent.TestNotificationProcessor
[INFO] Running org.apache.sentry.provider.db.service.persistent.TestSentryStore
[INFO] Tests run: 75, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 28.159 
s - in org.apache.sentry.provider.db.service.persistent.TestSentryStore
[INFO] Running 
org.apache.sentry.provider.db.service.persistent.TestSentryPrivilege
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.418 s 
- in org.apache.sentry.provider.db.service.persistent.TestSentryPrivilege
[INFO] Running org.apache.sentry.provider.db.service.persistent.TestCounterWait
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.144 s 
- in org.apache.sentry.provider.db.service.persistent.TestCounterWait
[INFO] Running org.apache.sentry.provider.db.service.model.TestMSentryUtil
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.397 s 
- in org.apache.sentry.provider.db.service.model.TestMSentryUtil
[INFO] Running 
org.apache.sentry.api.generic.thrift.TestAuditLogForSentryGenericService
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 9.065 s 
- in org.apache.sentry.api.generic.thrift.TestAuditLogForSentryGenericService
[INFO] Running 
org.apache.sentry.api.generic.thrift.TestSentryGenericServiceClient
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 35.979 s 
- in org.apache.sentry.api.generic.thrift.TestSentryGenericServiceClient
[INFO] Running 
org.apache.sentry.api.generic.thrift.TestSentryGenericPolicyProcessor
[INFO] Tests run: 7, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.93 s - 
in org.apache.sentry.api.generic.thrift.TestSentryGenericPolicyProcessor
[INFO] Running 
org.apache.sentry.api.generic.thrift.TestSentryGenericServiceIntegration
[INFO] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 12.545 
s - in org.apache.sentry.api.generic.thrift.TestSentryGenericServiceIntegration
[INFO] Running org.apache.sentry.api.service.thrift.TestSentryServiceFailureCase
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 23.033 s 
- in org.apache.sentry.api.service.thrift.TestSentryServiceFailureCase
[INFO] Running org.apache.sentry.api.service.thrift.TestSentryServerLogLevel
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.952 s 
- in org.apache.sentry.api.service.thrift.TestSentryServerLogLevel
[INFO] Running 
org.apache.sentry.api.service.thrift.TestSentryPolicyStoreProcessor
[INFO] Tests run: 8, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.73 s - 
in org.apache.sentry.api.service.thrift.TestSentryPolicyStoreProcessor
[INFO] Running 
org.apache.sentry.api.service.thrift.TestSentryWebServerWithoutSecurity
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 9.182 s 
- in org.apache.sentry.api.service.thrift.TestSentryWebServerWithoutSecurity
[INFO] Running 
org.apache.sentry.api.service.thrift.TestSentryWebServiceForAuthTypeNone
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4.987 s 
- in org.apache.sentry.api.service.thrift.TestSentryWebServiceForAuthTypeNone
[INFO] Running 
org.apache.sentry.api.service.thrift.TestSentryServiceForPoolWithKerberos
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.798 s 
- in org.apache.sentry.api.service.thrift.TestSentryServiceForPoolWithKerberos
[INFO] Running 
org.apache.sentry.api.service.thrift.TestSentryServerWithoutKerberos
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.292 s 
- in org.apache.sentry.api.service.thrift.TestSentryServerWithoutKerberos
[INFO] Running 
org.apache.sentry.api.service.thrift.TestSentryServiceImportExport
[INFO] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.953 s 
- in org.apache.sentry.api.service.thrift.TestSentryServiceImportExport
[INFO] Running 
org.apache.sentry.api.service.thrift.TestNotificationHandlerInvoker
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.404 s 
- in org.apache.sentry.api.service.thrift.TestNotificationHandlerInvoker
[INFO] Running 
org.apache.sentry.api.service.thrift.TestSentryServerForPoolWithoutKerberos
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 6.338 s 
- in org.apache.sentry.api.service.thrift.TestSentryServerForPoolWithoutKerberos
[INFO] Running org.apache.sentry.api.service.thrift.TestSentryWebServerWithSSL
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 9.233 s 
- in org.apache.sentry.api.service.thrift.TestSentryWebServerWithSSL
[INFO] Running org.apache.sentry.api.service.thrift.TestSentryServiceIntegration
[INFO] Tests run: 19, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 15.324 
s - in org.apache.sentry.api.service.thrift.TestSentryServiceIntegration
[INFO] Running 
org.apache.sentry.api.service.thrift.TestSentryPolicyServiceClient
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 36.112 s 
- in org.apache.sentry.api.service.thrift.TestSentryPolicyServiceClient
[INFO] Running 
org.apache.sentry.api.service.thrift.TestSentryWebServerWithKerberos
[INFO] Tests run: 6, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 9.439 s 
- in org.apache.sentry.api.service.thrift.TestSentryWebServerWithKerberos
[INFO] Running 
org.apache.sentry.api.service.thrift.TestSentryServiceWithInvalidMsgSize
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 41.007 s 
- in org.apache.sentry.api.service.thrift.TestSentryServiceWithInvalidMsgSize
[INFO] Running org.apache.sentry.api.service.thrift.TestSentryServiceClientPool
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 41.016 s 
- in org.apache.sentry.api.service.thrift.TestSentryServiceClientPool
[INFO] Running org.apache.sentry.api.service.thrift.TestSentryServerPubSub
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 8.348 s 
- in org.apache.sentry.api.service.thrift.TestSentryServerPubSub
[INFO] Running 
org.apache.sentry.api.service.thrift.TestConnectionWithTicketTimeout
[WARNING] Tests run: 1, Failures: 0, Errors: 0, Skipped: 1, Time elapsed: 0.042 
s - in org.apache.sentry.api.service.thrift.TestConnectionWithTicketTimeout
[INFO] Running 
org.apache.sentry.api.service.thrift.TestSentryServiceWithKerberos
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 7.915 s 
- in org.apache.sentry.api.service.thrift.TestSentryServiceWithKerberos
[INFO] Running 
org.apache.sentry.api.service.thrift.TestAuthorizingDDLAuditLogWithKerberos
[INFO] Tests run: 1, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 9.273 s 
- in org.apache.sentry.api.service.thrift.TestAuthorizingDDLAuditLogWithKerberos
[INFO] Running org.apache.sentry.api.service.thrift.TestSentryServiceMetrics
[INFO] Tests run: 2, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 10.196 s 
- in org.apache.sentry.api.service.thrift.TestSentryServiceMetrics
[INFO] Running org.apache.sentry.service.thrift.TestSentryHMSClient
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.97 s - 
in org.apache.sentry.service.thrift.TestSentryHMSClient
[INFO] Running org.apache.sentry.service.thrift.TestHiveNotificationFetcher
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.678 s 
- in org.apache.sentry.service.thrift.TestHiveNotificationFetcher
[INFO] Running org.apache.sentry.service.thrift.TestSentryStateBank
[INFO] Tests run: 4, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 0.156 s 
- in org.apache.sentry.service.thrift.TestSentryStateBank
[INFO] Running org.apache.sentry.service.thrift.TestFullUpdateInitializer
[INFO] Tests run: 3, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 47.352 s 
- in org.apache.sentry.service.thrift.TestFullUpdateInitializer
[INFO] Running org.apache.sentry.service.thrift.TestFullUpdateModifier
[INFO] Tests run: 16, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.137 s 
- in org.apache.sentry.service.thrift.TestFullUpdateModifier
[INFO]
[INFO] Results:
[INFO]
[WARNING] Tests run: 340, Failures: 0, Errors: 0, Skipped: 2
[INFO]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 09:19 min
[INFO] Finished at: 2018-06-21T09:32:56-05:00
[INFO] Final Memory: 44M/900M
[INFO] ------------------------------------------------------------------------
{noformat}

> Fix URI check on List Privileges by Provider in SentryStore
> -----------------------------------------------------------
>
>                 Key: SENTRY-2231
>                 URL: https://issues.apache.org/jira/browse/SENTRY-2231
>             Project: Sentry
>          Issue Type: Bug
>          Components: Sentry
>    Affects Versions: 2.1.0
>            Reporter: Arjun Mishra
>            Assignee: Arjun Mishra
>            Priority: Major
>             Fix For: 2.0.0
>
>         Attachments: SENTRY-2231.01.patch
>
>
> In SentryStore#getMSentryPrivileges when retrieving URI's the query condition 
> "addCustomParam("\"" + authHierarchy.getUri() + "\".startsWith(:URI)", URI, 
> authHierarchy.getUri());", will always be True. This should be changed to 
> filter by appropriate URI.
> For example: when retrieving privileges on URI object "/x/y/z" this condition 
> is checked for: ""file:///x/y/z".startsWith(file:///x/y/z))", which is always 
> true



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to