[ 
https://issues.apache.org/jira/browse/SENTRY-1944?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584326#comment-16584326
 ] 

Hadoop QA commented on SENTRY-1944:
-----------------------------------

Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12936072/SENTRY-1944.08.patch 
against master.

{color:red}Overall:{color} -1 due to 5 errors

{color:red}ERROR:{color} mvn test exited 1
{color:red}ERROR:{color} Failed: 
org.apache.sentry.api.generic.thrift.TestSentryGenericServiceIntegration
{color:red}ERROR:{color} Failed: 
org.apache.sentry.api.generic.thrift.TestSentryGenericServiceIntegration
{color:red}ERROR:{color} Failed: 
org.apache.sentry.api.generic.thrift.TestSentryGenericServiceIntegration
{color:red}ERROR:{color} Failed: 
org.apache.sentry.api.generic.thrift.TestSentryGenericServiceIntegration

Console output: 
https://builds.apache.org/job/PreCommit-SENTRY-Build/4050/console

This message is automatically generated.

> Optimize DelegateSentryStore.getGroupsByRoles() and update 
> SentryGenericPolicyProcessor  to retrieve roles to group mapping in a single 
> transaction
> ---------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SENTRY-1944
>                 URL: https://issues.apache.org/jira/browse/SENTRY-1944
>             Project: Sentry
>          Issue Type: Improvement
>          Components: Sentry
>    Affects Versions: 2.0.0
>            Reporter: Alexander Kolbasov
>            Assignee: Arjun Mishra
>            Priority: Major
>         Attachments: SENTRY-1944.01.patch, SENTRY-1944.02.patch, 
> SENTRY-1944.03.patch, SENTRY-1944.05.patch, SENTRY-1944.06.patch, 
> SENTRY-1944.07.patch, SENTRY-1944.08.patch
>
>
> When Solr is using Sentry server for authorization, it issues a lot of calls 
> to {{getGroupsByRoles()}} function in {{DelegateSentryStore}}.
> This function isn't very efficient - it walks over each role in the set, 
> obtains role by name, get groups for each role, and collects all group names 
> into a set.
> It may be possible to optimize it.
> Also, in SentryGenericPolicyProcessor class method 
> list_sentry_roles_by_group() would make N transactions to build the roles to 
> set of groups map. Instead, make it to a single transaction. This will 
> significantly speed up operation



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to