[
https://issues.apache.org/jira/browse/SENTRY-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16613768#comment-16613768
]
Hadoop QA commented on SENTRY-2074:
-----------------------------------
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12907172/SENTRY-2074.04.patch
against master.
{color:red}Overall:{color} -1 due to an error
{color:red}ERROR:{color} failed to apply patch (exit code 1):
error: a/pom.xml: does not exist in index
error: a/sentry-binding/pom.xml: does not exist in index
error: a/sentry-binding/sentry-binding-hbase-indexer/pom.xml: does not exist in
index
error: a/sentry-binding/sentry-binding-hive-common/pom.xml: does not exist in
index
error: a/sentry-binding/sentry-binding-hive-conf/pom.xml: does not exist in
index
error: a/sentry-binding/sentry-binding-hive-follower/pom.xml: does not exist in
index
error: a/sentry-binding/sentry-binding-hive/pom.xml: does not exist in index
error: a/sentry-binding/sentry-binding-kafka/pom.xml: does not exist in index
error: a/sentry-binding/sentry-binding-solr/pom.xml: does not exist in index
error: a/sentry-binding/sentry-binding-sqoop/pom.xml: does not exist in index
error: a/sentry-core/sentry-core-common/pom.xml: does not exist in index
error: a/sentry-core/sentry-core-model-db/pom.xml: does not exist in index
error: a/sentry-core/sentry-core-model-indexer/pom.xml: does not exist in index
error: a/sentry-core/sentry-core-model-kafka/pom.xml: does not exist in index
error: a/sentry-core/sentry-core-model-solr/pom.xml: does not exist in index
error: a/sentry-core/sentry-core-model-sqoop/pom.xml: does not exist in index
error: a/sentry-dist/pom.xml: does not exist in index
error: a/sentry-dist/src/license/THIRD-PARTY.properties: does not exist in index
error: a/sentry-dist/src/main/assembly/bin.xml: does not exist in index
error: a/sentry-hdfs/pom.xml: does not exist in index
error: a/sentry-hdfs/sentry-hdfs-common/pom.xml: does not exist in index
error: a/sentry-hdfs/sentry-hdfs-dist/pom.xml: does not exist in index
error: a/sentry-hdfs/sentry-hdfs-namenode-plugin/pom.xml: does not exist in
index
error: a/sentry-hdfs/sentry-hdfs-service/pom.xml: does not exist in index
error: a/sentry-policy/pom.xml: does not exist in index
error: a/sentry-policy/sentry-policy-common/pom.xml: does not exist in index
error:
a/sentry-policy/sentry-policy-common/src/main/java/org/apache/sentry/policy/common/PolicyEngine.java:
does not exist in index
error: a/sentry-policy/sentry-policy-engine/pom.xml: does not exist in index
error: a/sentry-provider/pom.xml: does not exist in index
error: a/sentry-provider/sentry-provider-cache/pom.xml: does not exist in index
error: a/sentry-provider/sentry-provider-common/pom.xml: does not exist in index
error: a/sentry-provider/sentry-provider-db/pom.xml: does not exist in index
error:
a/sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/CounterWait.java:
does not exist in index
error: a/sentry-provider/sentry-provider-file/pom.xml: does not exist in index
error: a/sentry-solr/pom.xml: does not exist in index
error: a/sentry-solr/solr-sentry-handlers/pom.xml: does not exist in index
error: a/sentry-tests/pom.xml: does not exist in index
error: a/sentry-tests/sentry-tests-hive-v2/pom.xml: does not exist in index
error: a/sentry-tests/sentry-tests-hive/pom.xml: does not exist in index
error: a/sentry-tests/sentry-tests-kafka/pom.xml: does not exist in index
error: a/sentry-tests/sentry-tests-solr/pom.xml: does not exist in index
error: a/sentry-tests/sentry-tests-sqoop/pom.xml: does not exist in index
error: a/sentry-tools/pom.xml: does not exist in index
error: patch failed: pom.xml:58
Falling back to three-way merge...
Applied patch to 'pom.xml' with conflicts.
error: patch failed: sentry-binding/sentry-binding-hive-common/pom.xml:29
Falling back to three-way merge...
Applied patch to 'sentry-binding/sentry-binding-hive-common/pom.xml' cleanly.
error: patch failed: sentry-binding/sentry-binding-hive/pom.xml:30
Falling back to three-way merge...
Applied patch to 'sentry-binding/sentry-binding-hive/pom.xml' with conflicts.
error: patch failed: sentry-binding/sentry-binding-kafka/pom.xml:60
Falling back to three-way merge...
Applied patch to 'sentry-binding/sentry-binding-kafka/pom.xml' cleanly.
error: patch failed: sentry-dist/pom.xml:200
Falling back to three-way merge...
Applied patch to 'sentry-dist/pom.xml' with conflicts.
error: patch failed: sentry-dist/src/license/THIRD-PARTY.properties:13
Falling back to three-way merge...
Applied patch to 'sentry-dist/src/license/THIRD-PARTY.properties' with
conflicts.
error: patch failed: sentry-hdfs/sentry-hdfs-common/pom.xml:135
Falling back to three-way merge...
Applied patch to 'sentry-hdfs/sentry-hdfs-common/pom.xml' with conflicts.
error: patch failed: sentry-hdfs/sentry-hdfs-service/pom.xml:64
Falling back to three-way merge...
Applied patch to 'sentry-hdfs/sentry-hdfs-service/pom.xml' with conflicts.
error: patch failed: sentry-provider/sentry-provider-db/pom.xml:29
Falling back to three-way merge...
Applied patch to 'sentry-provider/sentry-provider-db/pom.xml' with conflicts.
error:
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/provider/db/service/persistent/CounterWait.java:
does not exist in index
error: sentry-tests/sentry-tests-hive-v2/pom.xml: does not exist in index
error: patch failed: sentry-tests/sentry-tests-kafka/pom.xml:33
Falling back to three-way merge...
Applied patch to 'sentry-tests/sentry-tests-kafka/pom.xml' with conflicts.
error: patch failed: sentry-tests/sentry-tests-solr/pom.xml:15
Falling back to three-way merge...
Applied patch to 'sentry-tests/sentry-tests-solr/pom.xml' with conflicts.
error: patch failed: sentry-tools/pom.xml:16
Falling back to three-way merge...
Applied patch to 'sentry-tools/pom.xml' with conflicts.
fatal: git diff header lacks filename information when removing 2 leading
pathname components (line 61)
The patch does not appear to apply with p0, p1, or p2
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/4106/console
This message is automatically generated.
> Fix maven dependencies to have all directly used libraries defined
> ------------------------------------------------------------------
>
> Key: SENTRY-2074
> URL: https://issues.apache.org/jira/browse/SENTRY-2074
> Project: Sentry
> Issue Type: Improvement
> Components: Build
> Affects Versions: 2.0.0
> Reporter: Brian Towles
> Assignee: Brian Towles
> Priority: Major
> Attachments: SENTRY-2074.01.patch, SENTRY-2074.02.patch,
> SENTRY-2074.03.patch, SENTRY-2074.04.patch
>
>
> Using the maven dependency plugin to analyze the dependency usage for each
> module and put all directly used libraries in the pom. Clean-up the unused
> ones and adjust the scope of libraries only used for tests and provided
> libraries for plugins.
>
> The one of the primary motivations for this patch is to help on its way to
> cleaning up the distribution. Currently the dist module reads all
> dependencies no mater what scope they are and drops them into the distributed
> libs. This causes things like junit and ant to be pushed into the libs that
> are being distributed. With the changes to have direct dependencies always
> defined it allows us to take compile and runtime scopes only into account
> when dropping the libs needed.
> As well this identifies which libraries are provided already by environments
> where the plugins/bindings are going into. For example in the hive bindings,
> the hive and hadoop libraries need only be defined with "provided" scope,
> since with those application we want to use the hadoop and hive libraries
> that the applications already provide.
> This makes it a lot easier for shading and package shifting of the binding
> and plugins for libraries and versions of those libraries that are needed by
> the binding and might conflict with versions already in the application which
> the binding or plugin is going into. Guava is a major issue with this. Doing
> this short of shading based on the cleanup would allow us to rev Guava and
> use newer Guava features while not conflicting with the Guava version the
> application is using. By having the directly used dependency defined it gives
> us control over the exact version we are using and not be dependent on and
> having conflicts with the transitive dependencies of the application being
> embedded in.
> This patch will not really make the development process harder since the
> analysis of the dependencies needed automatically runs as part of the build
> and a failure occurs telling you which "used but undefined" and which
> "defined but unused" libraries are missing or in the pom. There is even an
> xml dump of the dependencies part need to put right into the pom. No
> additional runs or dependency analysis needs to take place.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
