[ https://issues.apache.org/jira/browse/SENTRY-1267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Na Li updated SENTRY-1267: -------------------------- Fix Version/s: (was: 2.1.0) > Improve skipSlowAndNotThreadSafeTests blacklist/whitelist > --------------------------------------------------------- > > Key: SENTRY-1267 > URL: https://issues.apache.org/jira/browse/SENTRY-1267 > Project: Sentry > Issue Type: Improvement > Components: Test > Affects Versions: 1.8.0 > Reporter: Gregory Chanan > Priority: Major > > We currently explicitly exclude certain non thread safe tests: > https://github.com/apache/sentry/blob/2109f42945cb132c4bf738649abf2935288d1e20/pom.xml#L897-L903 > Though it's nice that this list is in one place, this is unmaintainable as we > add more tests. The usual way of solving this is to define annotations > around the tests that define when they should run. E.g. in this case, there > are a bunch of non-thread safe tests that derive from > SentryGenericServiceIntegrationBase. We can just annotate this base class > with @NonThreadSafe or something, which will be less of a maintenance > headache. -- This message was sent by Atlassian JIRA (v7.6.3#76005)