[
https://issues.apache.org/jira/browse/SENTRY-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16688376#comment-16688376
]
Hadoop QA commented on SENTRY-2458:
-----------------------------------
Here are the results of testing the latest attachment
https://issues.apache.org/jira/secure/attachment/12948348/SENTRY-2458.001.patch
against master.
{color:red}Overall:{color} -1 due to an error
{color:red}ERROR:{color} failed to apply patch (exit code 1):
fatal: git apply: bad git-diff - inconsistent old filename on line 1409
error: cannot apply binary patch to
'sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.eot'
without full index line
Falling back to three-way merge...
error: cannot apply binary patch to
'sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.eot'
without full index line
error:
sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.eot:
patch does not apply
error: cannot apply binary patch to
'sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.ttf'
without full index line
Falling back to three-way merge...
error: cannot apply binary patch to
'sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.ttf'
without full index line
error:
sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.ttf:
patch does not apply
error: cannot apply binary patch to
'sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.woff'
without full index line
Falling back to three-way merge...
error: cannot apply binary patch to
'sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.woff'
without full index line
error:
sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.woff:
patch does not apply
error: cannot apply binary patch to
'sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.woff2'
without full index line
Falling back to three-way merge...
error: cannot apply binary patch to
'sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.woff2'
without full index line
error:
sentry-service/sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.woff2:
patch does not apply
error: cannot apply binary patch to
'sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.eot'
without full index line
Falling back to three-way merge...
error: cannot apply binary patch to
'sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.eot'
without full index line
error:
sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.eot:
patch does not apply
error: cannot apply binary patch to
'sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.ttf'
without full index line
Falling back to three-way merge...
error: cannot apply binary patch to
'sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.ttf'
without full index line
error:
sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.ttf:
patch does not apply
error: cannot apply binary patch to
'sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.woff'
without full index line
Falling back to three-way merge...
error: cannot apply binary patch to
'sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.woff'
without full index line
error:
sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.woff:
patch does not apply
error: cannot apply binary patch to
'sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.woff2'
without full index line
Falling back to three-way merge...
error: cannot apply binary patch to
'sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.woff2'
without full index line
error:
sentry-service/sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.woff2:
patch does not apply
error: patch failed: pom.xml:41
Falling back to three-way merge...
Applied patch to 'pom.xml' with conflicts.
error: src/license/THIRD-PARTY.properties: does not exist in index
error: src/main/assembly/bin.xml: does not exist in index
error: sentry-provider-db/pom.xml: does not exist in index
error: patch failed: pom.xml:33
Falling back to three-way merge...
Applied patch to 'pom.xml' with conflicts.
error: sentry-service-server/pom.xml: does not exist in index
error:
sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAdminServlet.java:
does not exist in index
error:
sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryWebServer.java:
does not exist in index
error:
sentry-service-server/src/main/java/org/apache/sentry/service/thrift/SentryService.java:
does not exist in index
error: sentry-service-server/src/main/webapp/css/bootstrap-theme.min.css: does
not exist in index
error: sentry-service-server/src/main/webapp/css/bootstrap.min.css: does not
exist in index
error:
sentry-service-server/src/test/java/org/apache/sentry/api/service/thrift/TestSentryWebServerWithoutSecurity.java:
does not exist in index
error:
sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/ConfServlet.java:
does not exist in index
error:
sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/LogLevelServlet.java:
does not exist in index
error:
sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/PubSubServlet.java:
does not exist in index
error:
sentry-service-server/src/main/java/org/apache/sentry/api/service/thrift/SentryAuthFilter.java:
does not exist in index
error: cannot apply binary patch to
'sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.eot'
without full index line
Falling back to three-way merge...
error: cannot apply binary patch to
'sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.eot'
without full index line
error:
sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.eot:
patch does not apply
error: cannot apply binary patch to
'sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.ttf'
without full index line
Falling back to three-way merge...
error: cannot apply binary patch to
'sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.ttf'
without full index line
error:
sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.ttf:
patch does not apply
error: cannot apply binary patch to
'sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.woff'
without full index line
Falling back to three-way merge...
error: cannot apply binary patch to
'sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.woff'
without full index line
error:
sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.woff:
patch does not apply
error: cannot apply binary patch to
'sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.woff2'
without full index line
Falling back to three-way merge...
error: cannot apply binary patch to
'sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.woff2'
without full index line
error:
sentry-service-web/src/main/webapp/static/bootstrap/fonts/glyphicons-halflings-regular.woff2:
patch does not apply
error: sentry-service-server/src/main/webapp/css/sentry.css: does not exist in
index
error: sentry-service-server/src/main/webapp/sentry.png: does not exist in index
error: cannot apply binary patch to
'sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.eot'
without full index line
Falling back to three-way merge...
error: cannot apply binary patch to
'sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.eot'
without full index line
error:
sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.eot:
patch does not apply
error: cannot apply binary patch to
'sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.ttf'
without full index line
Falling back to three-way merge...
error: cannot apply binary patch to
'sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.ttf'
without full index line
error:
sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.ttf:
patch does not apply
error: cannot apply binary patch to
'sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.woff'
without full index line
Falling back to three-way merge...
error: cannot apply binary patch to
'sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.woff'
without full index line
error:
sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.woff:
patch does not apply
error: cannot apply binary patch to
'sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.woff2'
without full index line
Falling back to three-way merge...
error: cannot apply binary patch to
'sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.woff2'
without full index line
error:
sentry-service-web/src/main/webapp/static/materialdesign/fonts/materialdesignicons-webfont.woff2:
patch does not apply
The patch does not appear to apply with p0, p1, or p2
Console output:
https://builds.apache.org/job/PreCommit-SENTRY-Build/4238/console
This message is automatically generated.
> Separate Web UI and service from service-server to prevent circular
> dependencies
> --------------------------------------------------------------------------------
>
> Key: SENTRY-2458
> URL: https://issues.apache.org/jira/browse/SENTRY-2458
> Project: Sentry
> Issue Type: Improvement
> Components: Service
> Affects Versions: 2.0.1
> Reporter: Brian Towles
> Assignee: Brian Towles
> Priority: Major
> Fix For: 2.2.0
>
> Attachments: SENTRY-2458.001.patch
>
>
> In order to additional modules to be added to Sentry there needs to be a
> separation of some of the features used by service-server into other modules.
> This will allow the web server to be pulled out from the base server and
> allow for additional modules to be able to add web services and functionality
> to the web interface without depending up the whole server module.
> It will use the SPI to dynamically include servlets and content from other
> modules.
> It creates a sentry-service-providers to allow for Server and sub modules SPI
> providers to be defined externally and not depended on directly.
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
