[
https://issues.apache.org/jira/browse/SCB-138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16310694#comment-16310694
]
ASF GitHub Bot commented on SCB-138:
------------------------------------
seanyinx commented on a change in pull request #98: SCB-138 use grpc
bidirectional streaming to connect alpha and omega
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/98#discussion_r159577726
##########
File path:
alpha/alpha-server/src/main/java/org/apache/servicecomb/saga/alpha/server/AlphaConfig.java
##########
@@ -42,37 +45,47 @@
@Value("${alpha.compensation.retry.delay:3000}")
private int delay;
- // TODO: 2017/12/27 to be filled with actual callbacks on completion of
SCB-138
+ // TODO: 2018/01/03 optimize reverse visit of the map instead of using
another map, namely omegaCallbacksReverse
@Bean
Map<String, Map<String, OmegaCallback>> omegaCallbacks() {
return new ConcurrentHashMap<>();
}
+ @Bean
+ Map<StreamObserver<GrpcCompensateCommand>, Pair<String, String>>
omegaCallbacksReverse() {
Review comment:
we use a shared omega callbacks map, in order to use it in service/instance
aware callback. why do we need a shared map here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [pack] omega's callback about transaction state
> -----------------------------------------------
>
> Key: SCB-138
> URL: https://issues.apache.org/jira/browse/SCB-138
> Project: Apache ServiceComb
> Issue Type: New Feature
> Components: Saga
> Reporter: Eric Lee
> Assignee: Eric Lee
> Fix For: java-chassis-1.0.0-m1
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> as a dev, i want to register callback function in the server side, so the
> server can send messages back to the client directly instead of establishing
> a new connection to the exact client with its corresponding uri.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
