[
https://issues.apache.org/jira/browse/SCB-180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16314482#comment-16314482
]
ASF GitHub Bot commented on SCB-180:
------------------------------------
coveralls commented on issue #490: [SCB-180] Hystrixcommand setter not set by
dynamic configuration
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/490#issuecomment-355735442
[](https://coveralls.io/builds/14928625)
Coverage increased (+0.001%) to 87.453% when pulling
**e5781b42200c69ef05b18a6e40b594d2880601a9 on mojieshui:scb-180** into
**a4720c6bf64b9b0c9769fd9031166a785fabc4cc on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Circuitbreak forceopen always true
> ----------------------------------
>
> Key: SCB-180
> URL: https://issues.apache.org/jira/browse/SCB-180
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
> Affects Versions: java-chassis-1.0.0-m1
> Reporter: mojieshui
> Assignee: mojieshui
>
> when use dynamic config with ConfigCenterConfigurationSource
> reproduce steps:
> 1. add dynamic config item
> "servicecomb.circuitBreaker.Consumer.forceOpen=true"
> 2. make any request, hystrixcommand will init and cached. the circuitbreaker
> is open.
> 3. delete dynamic config item
> "servicecomb.circuitBreaker.Consumer.forceOpen", Expected result is
> circuitbreaker change to the default value "false", but it keep always true,
> all request fail.
> in class HystrixCommandPropertiesExt
> this.circuitBreakerForceOpen = getProperty(propertyPrefix,
> "circuitBreaker",
> key,
> "forceOpen",
> {color:#d04437}builder.getCircuitBreakerForceOpen(),
> {color} DEFAULT_CIRCUITBREAKERFORCEOPEN);
> and builder's value was set by dynamic config, not the default value false,
> if config was set before hystixcommand init, default value will override, and
> you have to restart if you want to restore
>
> .withCircuitBreakerForceOpen(Configuration.INSTANCE.isCircuitBreakerForceOpen(groupname,
> invocation.getMicroserviceName(),
> invocation.getOperationMeta()
> .getMicroserviceQualifiedName()))
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
