[
https://issues.apache.org/jira/browse/SCB-184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16314549#comment-16314549
]
ASF GitHub Bot commented on SCB-184:
------------------------------------
WillemJiang commented on a change in pull request #492: [SCB-184]Provide
starters for Spring Cloud to using service-center and config-center
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/492#discussion_r160025475
##########
File path:
spring-boot-starter/spring-boot-starter-discovery/src/main/java/io/servicecomb/springboot/starter/discovery/CseDiscoveryClientConfiguration.java
##########
@@ -17,33 +17,17 @@
package io.servicecomb.springboot.starter.discovery;
import org.springframework.boot.autoconfigure.AutoConfigureBefore;
-import org.springframework.boot.autoconfigure.condition.ConditionalOnBean;
import org.springframework.cloud.client.discovery.DiscoveryClient;
import
org.springframework.cloud.client.discovery.noop.NoopDiscoveryClientAutoConfiguration;
-import org.springframework.cloud.netflix.zuul.filters.ZuulProperties;
import org.springframework.context.annotation.Bean;
import org.springframework.context.annotation.Configuration;
-import org.springframework.context.annotation.Primary;
-
-import io.servicecomb.core.provider.consumer.ConsumerProviderManager;
+import org.springframework.core.annotation.Order;
@AutoConfigureBefore(NoopDiscoveryClientAutoConfiguration.class)
@Configuration
public class CseDiscoveryClientConfiguration {
-
- @Bean
- public CseDiscoveryProperties cseDiscoveryProperties() {
- return new CseDiscoveryProperties();
- }
-
- @Bean
- @ConditionalOnBean(ZuulProperties.class)
- public CseRoutesProperties cseRoutesProperties(ConsumerProviderManager
manager) {
- return new CseRoutesProperties(manager);
- }
-
@Bean
- @Primary
+ @Order(5000)
Review comment:
Is there any other client need to be found?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Provide starters for Spring Cloud to using service-center and config-center
> ---------------------------------------------------------------------------
>
> Key: SCB-184
> URL: https://issues.apache.org/jira/browse/SCB-184
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
> Reporter: liubao
>
> we have already have starters for spring cloud to using ServiceComb as a
> whole component. Now we make these components small enough to let spring
> cloud users to do the following:
> 1. provide a starter to register spring cloud application to service center;
> 2. provide a starter to using config center for dynamic configuration;
> 3. provide a starter that implments DiscoveryClient and using @Loadbalanced
> RestTemplate and using ZuulProxy
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
