[
https://issues.apache.org/jira/browse/SCB-172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315631#comment-16315631
]
Yang Bo edited comment on SCB-172 at 1/8/18 3:46 AM:
-----------------------------------------------------
ServiceComb uses brave for reporting to zipkin server. So supporting V1 API
with the newer versions can be easily achieved as described in the brave
[README|https://github.com/openzipkin/brave/tree/master/brave]:
{code:title=Zipkin V1 Setup}
sender = URLConnectionSender.create("http://localhost:9411/api/v1/spans";)
reporter = AsyncReporter.builder(sender)
.build(SpanBytesEncoder.JSON_V1);
{code}
We can add an option for user to specify the API version of the zipkin server.
was (Author: yangbor):
[~njiang] ServiceComb uses brave for reporting to zipkin server. So supporting
V1 API with the newer versions can be easily achieved as described in the brave
[README|https://github.com/openzipkin/brave/tree/master/brave]:
{code:title=Zipkin V1 Setup}
sender = URLConnectionSender.create("http://localhost:9411/api/v1/spans";)
reporter = AsyncReporter.builder(sender)
.build(SpanBytesEncoder.JSON_V1);
{code}
We can add an option for user to specify the API version of the zipkin server.
> Upgrade to zipkin2
> ------------------
>
> Key: SCB-172
> URL: https://issues.apache.org/jira/browse/SCB-172
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
> Reporter: Yang Bo
> Assignee: Yang Bo
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> The upstream zipkin libraries are moving to use the v2 http api introduced in
> zipkin-1.31. It's also including other features and improvements.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
