[
https://issues.apache.org/jira/browse/SCB-228?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16325162#comment-16325162
]
ASF GitHub Bot commented on SCB-228:
------------------------------------
zhfeng commented on a change in pull request #115: SCB-228 Update to replace
the type of TxEvent with Enum
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/115#discussion_r161373968
##########
File path:
omega/omega-connector/omega-connector-grpc/src/test/java/org/apache/servicecomb/saga/omega/connector/grpc/LoadBalancedClusterMessageSenderTest.java
##########
@@ -291,10 +291,12 @@ private MyTxEventService(Queue<String> connected,
Queue<TxEvent> events, int del
public void onConnected(GrpcServiceConfig request,
StreamObserver<GrpcCompensateCommand> responseObserver) {
this.responseObserver = responseObserver;
connected.add("Connected " + request.getServiceName());
+ System.out.println("Connected " + request.getServiceName());
Review comment:
This is just for debugging. The tests pass on my local machine but the CI
report the failure.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update to replace the type of TxEvent with Enum
> -----------------------------------------------
>
> Key: SCB-228
> URL: https://issues.apache.org/jira/browse/SCB-228
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Saga
> Reporter: Zheng Feng
> Assignee: Zheng Feng
> Fix For: saga-0.3.0
>
>
> Currently the type of TxEvent is with the className such as
> {code}
> public String type() {
> return this.getClass().getSimpleName();
> }
> {code}
> It could be better with the Enum value since we could have changed the event
> class name in the future.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
