[
https://issues.apache.org/jira/browse/SCB-233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16325979#comment-16325979
]
ASF GitHub Bot commented on SCB-233:
------------------------------------
zhfeng commented on a change in pull request #119: SCB-233 update to deploy
only with non PR building
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/119#discussion_r161449469
##########
File path: .travis.yml
##########
@@ -27,7 +27,7 @@ script:
- mvn clean install -Pjacoco -Pdocker coveralls:report
- mvn clean verify -f saga-demo -Pdemo -Pdocker -Ddocker.useColor=false
-Ddocker.showLogs
after_success:
-- mvn deploy -DskipTests --settings .travis.settings.xml
+- if [ "$TRAVIS_PULL_REQUEST" = "false" ]; then mvn deploy -DskipTests
--settings .travis.settings.xml; fi
Review comment:
see http://docs.travis-ci.com/user/ci-environment/
TRAVIS_BRANCH
* for push builds, or builds not triggered by a pull request, this is the
name of the branch.
* for builds triggered by a pull request this is the name of the branch
targeted by the pull request.
* for builds triggered by a tag, this is the same as the name of the tag
(TRAVIS_TAG).
So it looks like in many case of the pull request, the branch target is
"master".
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Don't deploy if building with the PR
> ------------------------------------
>
> Key: SCB-233
> URL: https://issues.apache.org/jira/browse/SCB-233
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Saga
> Reporter: Zheng Feng
> Assignee: Zheng Feng
> Priority: Major
> Fix For: saga-0.3.0
>
>
> currently the travis CI runs the deploy command when building with the PR. we
> should improve this step.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
