[
https://issues.apache.org/jira/browse/SCB-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16326300#comment-16326300
]
ASF GitHub Bot commented on SCB-234:
------------------------------------
WillemJiang commented on a change in pull request #120: SCB-234 fail fast at
SagaStart if all alpha clusters are down
URL:
https://github.com/apache/incubator-servicecomb-saga/pull/120#discussion_r161537114
##########
File path:
omega/omega-connector/omega-connector-grpc/src/main/java/org/apache/servicecomb/saga/omega/connector/grpc/LoadBalancedClusterMessageSender.java
##########
@@ -150,13 +155,15 @@ private MessageSender fastestSender() {
.filter(entry -> entry.getValue() < Long.MAX_VALUE)
.min(Comparator.comparingLong(Entry::getValue))
.map(Entry::getKey)
- .orElse((event -> {
+ .orElse(event -> {
+ clusterStatus.setHealthy(false);
Review comment:
The clusterStatus check and setting is not atomic. maybe we should consider
to use single thread to send the event message.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> [pack] fail fast if alpha cluster down
> --------------------------------------
>
> Key: SCB-234
> URL: https://issues.apache.org/jira/browse/SCB-234
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Saga
> Reporter: Yin Xiang
> Assignee: Eric Lee
> Priority: Major
> Fix For: saga-0.1.0
>
>
> when alpha cluster is down, future transactions should fail immediately at
> @SagaStart instead of keep retrying, in order not to stress the services
> further by blocking all the request threads.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
