[
https://issues.apache.org/jira/browse/SCB-180?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Willem Jiang resolved SCB-180.
------------------------------
Resolution: Fixed
The PR was merged into master branch.
> Circuitbreak forceopen always true
> ----------------------------------
>
> Key: SCB-180
> URL: https://issues.apache.org/jira/browse/SCB-180
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
> Reporter: mojieshui
> Assignee: mojieshui
> Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> when use dynamic config with ConfigCenterConfigurationSource
> reproduce steps:
> 1. add dynamic config item
> "servicecomb.circuitBreaker.Consumer.forceOpen=true"
> 2. make any request, hystrixcommand will init and cached. the circuitbreaker
> is open.
> 3. delete dynamic config item
> "servicecomb.circuitBreaker.Consumer.forceOpen", Expected result is
> circuitbreaker change to the default value "false", but it keep always true,
> all request fail.
> in class HystrixCommandPropertiesExt
> {code}
> this.circuitBreakerForceOpen = getProperty(propertyPrefix,
> "circuitBreaker",
> key,
> "forceOpen",
> builder.getCircuitBreakerForceOpen(),
> DEFAULT_CIRCUITBREAKERFORCEOPEN);
> {code}
> and builder's value was set by dynamic config, not the default value false,
> if config was set before hystixcommand init, default value will override, and
> you have to restart if you want to restore
> {code}
>
> .withCircuitBreakerForceOpen(Configuration.INSTANCE.isCircuitBreakerForceOpen(groupname,
> invocation.getMicroserviceName(),
> invocation.getOperationMeta()
> .getMicroserviceQualifiedName()))
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
