[
https://issues.apache.org/jira/browse/SCB-12?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16328074#comment-16328074
]
ASF GitHub Bot commented on SCB-12:
-----------------------------------
WillemJiang commented on a change in pull request #510: [SCB-12] Support Custom
Metrics
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/510#discussion_r161717861
##########
File path:
metrics/metrics-core/src/test/java/org/apache/servicecomb/metrics/core/TestHealthCheckerManager.java
##########
@@ -84,5 +97,8 @@ public void testRegistry() throws IOException {
Assert.assertTrue(data.getInstanceId().equals("001"));
Review comment:
It makes sense to use the assertEquals instead of assertTrue here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Support Custom Metrics
> ----------------------
>
> Key: SCB-12
> URL: https://issues.apache.org/jira/browse/SCB-12
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
> Reporter: yangyongzheng
> Assignee: yangyongzheng
> Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> User can inject custom business metrics into MetricsRegistry then get them
> back with build-in metrics together,need support this basic metric type:
> 1.Counter
> 2.Guage
> 3.Max
> 4.Min
> 5.Rate
> 6.Custom Callback with Fun0
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
