[
https://issues.apache.org/jira/browse/SCB-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332045#comment-16332045
]
ASF GitHub Bot commented on SCB-255:
------------------------------------
codecov-io commented on issue #250: SCB-255 logrotate bug fix ,non write
permission, skip
URL:
https://github.com/apache/incubator-servicecomb-service-center/pull/250#issuecomment-358647885
#
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/250?src=pr&el=h1)
Report
> Merging
[#250](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/250?src=pr&el=desc)
into
[master](https://codecov.io/gh/apache/incubator-servicecomb-service-center/commit/834e377aa8f00b90be70a97330e7fc96ef29512f?src=pr&el=desc)
will **decrease** coverage by `0.02%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/250?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #250 +/- ##
=========================================
- Coverage 69.43% 69.4% -0.03%
=========================================
Files 17 17
Lines 3537 3537
=========================================
- Hits 2456 2455 -1
Misses 913 913
- Partials 168 169 +1
```
| [Impacted
Files](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/250?src=pr&el=tree)
| Coverage Δ | |
|---|---|---|
|
[server/service/service\_dependency.go](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/250/diff?src=pr&el=tree#diff-c2VydmVyL3NlcnZpY2Uvc2VydmljZV9kZXBlbmRlbmN5Lmdv)
| `74.78% <0%> (-0.87%)` | :arrow_down: |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/250?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/250?src=pr&el=footer).
Last update
[834e377...b0d74b1](https://codecov.io/gh/apache/incubator-servicecomb-service-center/pull/250?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Optimize log rotate lib
> -----------------------
>
> Key: SCB-255
> URL: https://issues.apache.org/jira/browse/SCB-255
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Service-Center
> Reporter: little-cui
> Assignee: little-cui
> Priority: Major
> Fix For: service-center-1.0.0-m1
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
