[
https://issues.apache.org/jira/browse/SCB-308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342986#comment-16342986
]
ASF GitHub Bot commented on SCB-308:
------------------------------------
jeho0815 opened a new pull request #539: SCB-308 Vertx transport server timeout
will cause VertxServerRequestT…
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/539
…oHttpServletRequest getRemoteAddress NullPointException, so save the
socketAddress with the servletRequest
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/SCB) filed for the change (usually
before you start working on it). Trivial changes like typos do not require a
JIRA issue. Your pull request should address just this issue, without pulling
in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[SCB-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `SCB-XXX` with the appropriate JIRA
issue.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Vertx transport server timeout will cause
> VertxServerRequestToHttpServletRequest getRemoteAddress NullPointException
> --------------------------------------------------------------------------------------------------------------------
>
> Key: SCB-308
> URL: https://issues.apache.org/jira/browse/SCB-308
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
> Affects Versions: java-chassis-1.0.0-m1
> Reporter: jeho0815
> Assignee: jeho0815
> Priority: Major
>
> VertxServerRequestToHttpServletRequest use the the vertx HttpServerRequest
> socketAddress, this will call the netty channel to get remote addtess, but
> server has timeout, so the remote address has been released and return null.
> so we have to bind the socketaddress to the ServletRequest
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
