[ https://issues.apache.org/jira/browse/SCB-239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16355432#comment-16355432 ]
ASF GitHub Bot commented on SCB-239: ------------------------------------ seanyinx commented on a change in pull request #122: SCB-239 omega stateless URL: https://github.com/apache/incubator-servicecomb-saga/pull/122#discussion_r166616059 ########## File path: alpha/alpha-core/src/main/java/org/apache/servicecomb/saga/alpha/core/EventScanner.java ########## @@ -64,16 +67,32 @@ public void run() { private void pollEvents() { scheduler.scheduleWithFixedDelay( () -> { + updateTimeoutStatus(); + findTimeoutEvents(); + abortTimeoutEvents(); saveUncompensatedEventsToCommands(); compensate(); updateCompensatedCommands(); deleteDuplicateSagaEndedEvents(); + updateTransactionStatus(); }, 0, eventPollingInterval, MILLISECONDS); } + private void findTimeoutEvents() { + eventRepository.findTimeoutEvents() + .forEach(event -> { + log.info("Found timeout event {}", event); + timeoutRepository.save(txTimeoutOf(event)); Review comment: will this create duplicate timeout entries when multiple alphas work on the same event?? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > [pack] omega recovery > --------------------- > > Key: SCB-239 > URL: https://issues.apache.org/jira/browse/SCB-239 > Project: Apache ServiceComb > Issue Type: Improvement > Components: Saga > Affects Versions: saga-0.1.0 > Reporter: Eric Lee > Assignee: Eric Lee > Priority: Major > Fix For: saga-0.1.0 > > > as a user, I want to have the pending data stored persistently and be able to > resume the execution of these data if omega fails. -- This message was sent by Atlassian JIRA (v7.6.3#76005)