[
https://issues.apache.org/jira/browse/SCB-373?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16392542#comment-16392542
]
ASF GitHub Bot commented on SCB-373:
------------------------------------
wujimin commented on a change in pull request #578: SCB-373 change Rest args
code/encoding to HttpClientFilter/HttpServer…
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/578#discussion_r173383416
##########
File path:
common/common-rest/src/main/java/org/apache/servicecomb/common/rest/filter/inner/ClientRestArgsFilter.java
##########
@@ -0,0 +1,58 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.servicecomb.common.rest.filter.inner;
+
+import org.apache.servicecomb.common.rest.RestConst;
+import org.apache.servicecomb.common.rest.codec.RestCodec;
+import org.apache.servicecomb.common.rest.codec.param.RestClientRequestImpl;
+import org.apache.servicecomb.common.rest.definition.RestOperationMeta;
+import org.apache.servicecomb.common.rest.filter.HttpClientFilter;
+import org.apache.servicecomb.core.Invocation;
+import org.apache.servicecomb.core.definition.OperationMeta;
+import org.apache.servicecomb.foundation.vertx.http.HttpServletRequestEx;
+import org.apache.servicecomb.foundation.vertx.http.HttpServletResponseEx;
+import org.apache.servicecomb.swagger.invocation.Response;
+import org.apache.servicecomb.swagger.invocation.exception.ExceptionFactory;
+
+public class ClientRestArgsFilter implements HttpClientFilter {
+
+ @Override
+ public int getOrder() {
+ return -100;
+ }
+
+ @Override
+ public void beforeSendRequest(Invocation invocation, HttpServletRequestEx
requestEx) {
+ RestClientRequestImpl restClientRequest = (RestClientRequestImpl)
invocation.getHandlerContext()
+ .get(RestConst.INVOCATION_HANDLER_REQUESTCLIENT);
+ OperationMeta operationMeta = invocation.getOperationMeta();
+ RestOperationMeta swaggerRestOperation =
operationMeta.getExtData(RestConst.SWAGGER_REST_OPERATION);
+ try {
+ RestCodec.argsToRest(invocation.getArgs(), swaggerRestOperation,
restClientRequest);
+ requestEx.setBodyBuffer(restClientRequest.getBodyBuffer());
+ } catch (Exception e) {
Review comment:
it's better to catch throwable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> As a developer, i want to do something around serialize/deserialize, so that
> we should make a aspect to eanable others can do this work
> ----------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SCB-373
> URL: https://issues.apache.org/jira/browse/SCB-373
> Project: Apache ServiceComb
> Issue Type: Improvement
> Components: Java-Chassis
> Reporter: jeho0815
> Assignee: jeho0815
> Priority: Major
> Fix For: java-chassis-1.0.0-m2
>
>
> somebody want to use Jackson StdDeserializer/StdSerializer to encode or
> decode paramters， but the method can't send any parameters into it. So we can
> only use ThreadLocal to transfer. To support this, we may move RestCodec to
> HttpServerFilter，other guys can do some work in their own Filters before this.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
