[
https://issues.apache.org/jira/browse/SCB-396?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16399842#comment-16399842
]
ASF GitHub Bot commented on SCB-396:
------------------------------------
wujimin commented on a change in pull request #591: [SCB-396] java-sdk needs to
distinguish the services belongs to the devops stage(environment)
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/591#discussion_r174667006
##########
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/api/registry/MicroserviceFactory.java
##########
@@ -60,6 +62,7 @@ private Microservice
createMicroserviceFromDefinition(Configuration configuratio
microservice.setPaths(ConfigurePropertyUtils.getMicroservicePaths(configuration));
Map<String, String> propertiesMap =
MicroservicePropertiesLoader.INSTANCE.loadProperties(configuration);
microservice.setProperties(propertiesMap);
+ microservice.setEnvironment(configuration.getString(SERVICECOMB_ENV,
DEFAULT_SERVICECOMB_ENV));
Review comment:
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> java-sdk needs to distinguish the instance belongs to the devops
> stage(environment)
> -----------------------------------------------------------------------------------
>
> Key: SCB-396
> URL: https://issues.apache.org/jira/browse/SCB-396
> Project: Apache ServiceComb
> Issue Type: Task
> Components: Java-Chassis
> Reporter: WeiChao
> Assignee: WeiChao
> Priority: Major
> Fix For: service-center-1.0.0-m2
>
>
> sdk support registers service environment according to environment variables.
> servcie center registers the service interface, requesting the field with the
> identification phase in the body,\{"service":{"serviceId":"xxx",
> "environment":"production"}}.
> the name of the environment variable should be aligned with GOSDK and be
> unified.
> the default value of this field is blank.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
