[
https://issues.apache.org/jira/browse/SCB-386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16400102#comment-16400102
]
ASF GitHub Bot commented on SCB-386:
------------------------------------
WillemJiang closed pull request #603: [SCB-386] fix metrics samples readme
URL: https://github.com/apache/incubator-servicecomb-java-chassis/pull/603
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/samples/metrics-extend-healthcheck/README.md
b/samples/metrics-extend-healthcheck/README.md
index 7abd17311..97bac1b66 100644
--- a/samples/metrics-extend-healthcheck/README.md
+++ b/samples/metrics-extend-healthcheck/README.md
@@ -32,6 +32,11 @@ In this demo,we had make two checkers :
</dependency>
```
+### Start service
+```bash
+mvn spring-boot:run
+```
+
### Do check and get result
If you had config rest transport address in microservice.yaml like:
```yaml
diff --git a/samples/metrics-write-file-sample/README.md
b/samples/metrics-write-file-sample/README.md
index b6e041636..8f3a32c92 100644
--- a/samples/metrics-write-file-sample/README.md
+++ b/samples/metrics-write-file-sample/README.md
@@ -15,4 +15,14 @@ This module contain log4j2 MetricsFileWriter implement if
your project use it as
This module contain log4j MetricsFileWriter implement if your project use it
as Logging component.
## How to use
-Startup ServiceApplication in metrics-write-file-log4j2-springboot or
metrics-write-file-log4j-springboot,you can see metric files had generated in
**target/metric** folder,open your browser and make a request to
http://localhost:8080/f ,wait a moment then you can see invocation metric files
also be generated.
\ No newline at end of file
+Startup ServiceApplication in metrics-write-file-log4j2-springboot or
metrics-write-file-log4j-springboot
+
+1. If start service by maven
+```bash
+mvn spring-boot:run
+```
+you can see metric files had generated in
**samples/metrics-write-file-sample/metrics-write-file-log4j(log4j2)-springboot/target/metric**
folder,open your browser and make a request to http://localhost:8080/f ,wait a
moment then you can see invocation metric files also be generated.
+
+2. If start service by IDE
+
+you can see metric files had generated in **target/metric** folder,open your
browser and make a request to http://localhost:8080/f ,wait a moment then you
can see invocation metric files also be generated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Update all java chassis samples ReadMe file add "how to verify" chapter
> -----------------------------------------------------------------------
>
> Key: SCB-386
> URL: https://issues.apache.org/jira/browse/SCB-386
> Project: Apache ServiceComb
> Issue Type: Bug
> Components: Java-Chassis
> Affects Versions: java-chassis-1.0.0-m1
> Reporter: yangyongzheng
> Assignee: yangyongzheng
> Priority: Major
> Fix For: java-chassis-1.0.0-m1
>
>
> In those files how to verify producer had correct startup and how to check
> consumer had correct acted are missing
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
