[
https://issues.apache.org/jira/browse/SCB-385?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16421508#comment-16421508
]
ASF GitHub Bot commented on SCB-385:
------------------------------------
WillemJiang commented on a change in pull request #628: [SCB-385] Metrics
publisher switch to new mechanism
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/628#discussion_r178444270
##########
File path:
service-registry/src/main/java/org/apache/servicecomb/serviceregistry/registry/AbstractServiceRegistry.java
##########
@@ -195,16 +195,11 @@ private boolean needSetFrameworkVersion() {
if (serviceCenterInfo == null) {
LOGGER.warn("Server startup when service center not started and cannot
retrieve version info, assume latest.");
return true;
- } else {
- Version scVersion =
VersionUtils.getOrCreate(serviceCenterInfo.getVersion());
- Version frameworkVersion =
VersionUtils.getOrCreate(Const.SERVICECENTER_FRAMEWORK_VERSION);
-
- if (scVersion.compareTo(frameworkVersion) >= 0) {
- return true;
- } else {
- return false;
- }
}
+
Review comment:
This change doesn't relate to this JIRA, we need to avoid mixing the
unrelated changes together.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> metrics publisher switch to new mechanism
> -----------------------------------------
>
> Key: SCB-385
> URL: https://issues.apache.org/jira/browse/SCB-385
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
> Reporter: wujimin
> Assignee: wujimin
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
