[
https://issues.apache.org/jira/browse/SCB-422?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16426577#comment-16426577
]
ASF GitHub Bot commented on SCB-422:
------------------------------------
WillemJiang commented on a change in pull request #633: [SCB-422] Threadpool
metrics
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/633#discussion_r179373237
##########
File path:
metrics/metrics-core/src/main/java/org/apache/servicecomb/metrics/core/DefaultRegistryInitializer.java
##########
@@ -0,0 +1,64 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.servicecomb.metrics.core;
+
+import org.apache.servicecomb.foundation.metrics.MetricsBootstrapConfig;
+import org.apache.servicecomb.foundation.metrics.MetricsInitializer;
+
+import com.google.common.eventbus.EventBus;
+import com.netflix.servo.DefaultMonitorRegistry;
+import com.netflix.spectator.api.CompositeRegistry;
+import com.netflix.spectator.api.Registry;
+import com.netflix.spectator.servo.ServoRegistry;
+
+public class DefaultRegistryInitializer implements MetricsInitializer {
+ public static final String METRICS_WINDOW_TIME =
"servicecomb.metrics.window_time";
+
+ public static final int DEFAULT_METRICS_WINDOW_TIME = 5000;
+
+ public static final String SERVO_POLLERS = "servo.pollers";
+
+ private CompositeRegistry globalRegistry;
+
+ private ServoRegistry registry;
+
+ // create registry before init meters
+ @Override
+ public int getOrder() {
+ return -10;
+ }
+
+ @Override
+ public void init(CompositeRegistry globalRegistry, EventBus eventBus,
MetricsBootstrapConfig config) {
+ this.globalRegistry = globalRegistry;
+
+ System.getProperties().setProperty(SERVO_POLLERS,
String.valueOf(config.getMsPollInterval()));
+ registry = new ServoRegistry();
+
Review comment:
Do we need to clean up the System properties setting here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> add executor metrics, not just queue size
> -----------------------------------------
>
> Key: SCB-422
> URL: https://issues.apache.org/jira/browse/SCB-422
> Project: Apache ServiceComb
> Issue Type: Sub-task
> Components: Java-Chassis
> Reporter: wujimin
> Assignee: wujimin
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
