[
https://issues.apache.org/jira/browse/SCB-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16430000#comment-16430000
]
ASF GitHub Bot commented on SCB-456:
------------------------------------
liubao68 commented on a change in pull request #632: [SCB-456]Provider a way to
input configuration from a Map
URL:
https://github.com/apache/incubator-servicecomb-java-chassis/pull/632#discussion_r179982498
##########
File path:
foundations/foundation-config/src/test/java/org/apache/servicecomb/config/TestConfigUtil.java
##########
@@ -80,6 +81,16 @@ public static void tearDown() throws Exception {
ArchaiusUtils.resetConfig();
}
+ @Test
+ public void testAddConfig() {
+ Map config = new HashMap<String, Object>();
+ config.put("APPLICATION_ID", "app");
+ ConfigUtil.setConfigs(config);
+ ConcurrentCompositeConfiguration configuration =
ConfigUtil.createLocalConfig();
+ Assert.assertEquals(configuration.getString("APPLICATION_ID"), "app");
Review comment:
Can you provide a test case for dynamic property change is work? (callback)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Provider a way to input configuration from a Map, instead of
> micreservice.yaml
> -------------------------------------------------------------------------------
>
> Key: SCB-456
> URL: https://issues.apache.org/jira/browse/SCB-456
> Project: Apache ServiceComb
> Issue Type: Task
> Reporter: Minzhi Yan
> Assignee: Minzhi Yan
> Priority: Major
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
